Skip to content

feat: add overload for setdata #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

feat: add overload for setdata #68

merged 1 commit into from
Feb 23, 2022

Conversation

@peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Feb 23, 2022

Solves #66

@peterdeme peterdeme mentioned this pull request Feb 23, 2022
Closed
ferhatelmas
ferhatelmas approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas ferhatelmas merged commit 4e6a867 into master Feb 23, 2022
@ferhatelmas ferhatelmas deleted the add-overload branch February 23, 2022 13:07
@github-actions github-actions bot mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ferhatelmas ferhatelmas ferhatelmas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterdeme @ferhatelmas