Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/IReactions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,18 @@ public interface IReactions
/// <remarks>https://getstream.io/activity-feeds/docs/dotnet-csharp/reactions_introduction/?language=csharp</remarks>
Task<Reaction> AddAsync(string kind, string activityId, string userId, IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null);

/// <summary>Adds a new child reaction.</summary>
/// <remarks>https://getstream.io/activity-feeds/docs/dotnet-csharp/reactions_introduction/?language=csharp</remarks>
Task<Reaction> AddChildAsync(string parentId, string reactionId, string kind, string userId, IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null);

/// <summary>Adds a new child reaction.</summary>
/// <remarks>https://getstream.io/activity-feeds/docs/dotnet-csharp/reactions_introduction/?language=csharp</remarks>
Task<Reaction> AddChildAsync(Reaction parent, string reactionId, string kind, string userId, IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null);

/// <summary>Adds a new child reaction.</summary>
/// <remarks>https://getstream.io/activity-feeds/docs/dotnet-csharp/reactions_introduction/?language=csharp</remarks>
Task<Reaction> AddChildAsync(string parentId, string kind, string userId, IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null);

/// <summary>Adds a new child reaction.</summary>
/// <remarks>https://getstream.io/activity-feeds/docs/dotnet-csharp/reactions_introduction/?language=csharp</remarks>
Task<Reaction> AddChildAsync(Reaction parent, string kind, string userId, IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null);
Expand Down
18 changes: 15 additions & 3 deletions src/Reactions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,16 @@ public async Task<Reaction> AddAsync(string reactionId, string kind, string acti
public async Task<Reaction> AddChildAsync(Reaction parent, string kind, string userId,
IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null)
{
return await AddChildAsync(parent, null, kind, userId, data, targetFeeds);
return await AddChildAsync(parent.Id, null, kind, userId, data, targetFeeds);
}

public async Task<Reaction> AddChildAsync(Reaction parent, string reactionId, string kind, string userId,
public async Task<Reaction> AddChildAsync(string parentId, string kind, string userId,
IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null)
{
return await AddChildAsync(parentId, null, kind, userId, data, targetFeeds);
}

public async Task<Reaction> AddChildAsync(string parentId, string reactionId, string kind, string userId,
IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null)
{
var r = new Reaction()
Expand All @@ -55,13 +61,19 @@ public async Task<Reaction> AddChildAsync(Reaction parent, string reactionId, st
Kind = kind,
UserId = userId,
Data = data,
ParentId = parent.Id,
ParentId = parentId,
TargetFeeds = targetFeeds,
};

return await AddAsync(r);
}

public async Task<Reaction> AddChildAsync(Reaction parent, string reactionId, string kind, string userId,
IDictionary<string, object> data = null, IEnumerable<string> targetFeeds = null)
{
return await AddChildAsync(parent.Id, reactionId, kind, userId, data, targetFeeds);
}

public async Task<Reaction> GetAsync(string reactionId)
{
var request = _client.BuildAppRequest($"reaction/{reactionId}/", HttpMethod.Get);
Expand Down
6 changes: 3 additions & 3 deletions tests/ReactionTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public async Task TestReactions()
// Add children
var c1 = await Client.Reactions.AddChildAsync(r, "upvote", "tommy");
var c2 = await Client.Reactions.AddChildAsync(r, "downvote", "timmy");
var c3 = await Client.Reactions.AddChildAsync(r, "upvote", "jimmy");
var c3 = await Client.Reactions.AddChildAsync(r.Id, "upvote", "jimmy");

var parent = await Client.Reactions.GetAsync(r.Id);

Expand Down Expand Up @@ -125,7 +125,7 @@ public async Task TestReactionPagination()
var r3 = await Client.Reactions.AddAsync("like", activity.Id, "bob", data);

var r4 = await Client.Reactions.AddChildAsync(r3, "upvote", "tom", data);
var r5 = await Client.Reactions.AddChildAsync(r3, Guid.NewGuid().ToString(), "upvote", "mary", data);
var r5 = await Client.Reactions.AddChildAsync(r3.Id, Guid.NewGuid().ToString(), "upvote", "mary", data);

// activity id
var filter = ReactionFiltering.Default;
Expand Down Expand Up @@ -205,4 +205,4 @@ public async Task TestReactionPagination()
Assert.AreEqual(r5.UserId, actual.UserId);
}
}
}
}