Skip to content

Pin ty@0.0.24 to fix CI typecheck#229

Merged
aliev merged 1 commit intomainfrom
fix/pin-ty-version
Mar 26, 2026
Merged

Pin ty@0.0.24 to fix CI typecheck#229
aliev merged 1 commit intomainfrom
fix/pin-ty-version

Conversation

@aliev
Copy link
Copy Markdown
Member

@aliev aliev commented Mar 26, 2026

Why

ty 0.0.25 (released 2026-03-24) does not respect # type: ignore comments used throughout the codebase. When the uvx cache expired, CI started downloading 0.0.25 and typecheck began failing on all branches.

Changes

  • Pin ty@0.0.24 in Makefile typecheck target

Summary by CodeRabbit

  • Chores
    • Pinned the type checking tool version to ensure consistent builds and type validation across all development environments and automated processes.

ty 0.0.25 does not respect # type: ignore comments and reports
errors on lines that were previously suppressed. Pin to 0.0.24
until the codebase is migrated to ty: ignore syntax.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4d8c1cde-562a-4537-9692-53b7f99d3576

📥 Commits

Reviewing files that changed from the base of the PR and between 8ff29f0 and 5ad7c13.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The typecheck target in the Makefile was updated to pin the ty tool version to 0.0.24. The command now explicitly specifies uvx ty@0.0.24 check instead of uvx ty check, ensuring consistent type checking behavior across environments.

Changes

Cohort / File(s) Summary
Version Pinning
Makefile
Updated typecheck target to pin ty tool version to 0.0.24 for type checking consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version's pinned with care so bright,
ty@0.0.24 shines in the Makefile's light!
No more floating free on the wind,
Consistency's won, let the checks begin! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change: pinning the ty tool to version 0.0.24 to resolve CI typecheck failures caused by an incompatible newer version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pin-ty-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aliev aliev marked this pull request as ready for review March 26, 2026 12:41
@aliev aliev merged commit 22d53fb into main Mar 26, 2026
21 checks passed
@aliev aliev deleted the fix/pin-ty-version branch March 26, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants