Enrichment doesn't work with namespaced models

[adambedford]

Enrichment works by storing a reference to the model name in the format Name:ID, e.g. User:5. This doesn't work when the model name is namespaced, such as Namespaced::Model:5 -- splitting on :, results in ["Namespaced", "", "Model", "5"], which isn't what we want.

This should work, although I'm sure there's a more elegant way:

parts = value.split(":")
id = parts.pop
model = parts.reject(&:blank?).join("::")

[adambedford]

A better solution I think would be to change StreamRails.create_reference to underscore the model name so Namespaced::Model with an ID of 5 becomes namespaced/model:5, and, during enrichment, classify will correctly reassemble that to Namespaced::Model

[ayrton]

A more elegant ruby way to get the model (and id):

model, _, _id =  "Goals::Maker:1".rpartition(':')

[ayrton]

I've monkey patched the Gem to make this work in our app. We make use of namespaced models a lot:

module StreamRails
  class Enrich
    def model_field?(field_value)
      return false unless field_value.respond_to?('split')

      model, _, id = field_value.rpartition(':')
      return false unless model.present? && id.present?

      begin
        model.classify.constantize
      rescue NameError
        return false
      else
        return true
      end
    end

    def collect_references(activities)
      model_refs = Hash.new { |h, k| h[k] = {} }

      activities.each do |activity|
        activity.select { |k, _v| @fields.include? k.to_sym }.each do |_field, value|
          next unless model_field?(value)

          model, _, id = value.rpartition(':')
          model_refs[model][id] = 0
        end
      end

      model_refs
    end

    def inject_objects(activities, objects)
      create_activity_results(activities).each do |activity|
        activity.select { |k, _v| @fields.include? k.to_sym }.each do |field, value|
          next unless model_field?(value)

          model, _, id = value.rpartition(':')
          activity[field] = objects[model][id] || value
          activity.track_not_enriched_field(field, value) if objects[model][id].nil?
        end
      end
    end
  end
end