Remove webpack call from env.sh template#13
Merged
astrotars merged 1 commit intoGetStream:masterfrom Aug 24, 2016
napcs:napcs-webpack-fix
Merged
Remove webpack call from env.sh template#13astrotars merged 1 commit intoGetStream:masterfrom napcs:napcs-webpack-fix
astrotars merged 1 commit intoGetStream:masterfrom
napcs:napcs-webpack-fix
Conversation
The `env.sh` template creates `env.sh` on the prod server and runs as root. This fires webpack in the `app` folder but creates the `app/public/js/app.js` folder with `root` permissions. `env.sh` is sourced during deployment in `web.tpl`, causing the wrong permissions to be applied. Removing these lines from this template solves the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
env.shtemplate createsenv.shon the prod server and runs as root. This fires webpack in theappfolder but creates theapp/public/js/app.jsfolder withrootpermissions.env.shis sourced during deployment inweb.tpl, causing the wrong permissions to be applied. Removing these lines from this template solves the issue.