[PBE-5674] Add multiple services with different types for livestreaming calls #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandar-apostolov
changed the title
liviu-timar
reviewed
Aug 26, 2024
...tlin/io/getstream/video/android/core/notifications/internal/service/LivestreamCallService.kt
Show resolved
Hide resolved
liviu-timar
reviewed
Aug 26, 2024
…SCREEN_INTENT-purpose-in-Stream-SDK-for-Android-support-urgency' into PBE-5674-Inquiry-about-USE_FULL_SCREEN_INTENT-purpose-in-Stream-SDK-for-Android-support-urgency
…L_SCREEN_INTENT-purpose-in-Stream-SDK-for-Android-support-urgency # Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
liviu-timar
approved these changes
Aug 27, 2024
aleksandar-apostolov
deleted the
PBE-5674-Inquiry-about-USE_FULL_SCREEN_INTENT-purpose-in-Stream-SDK-for-Android-support-urgency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to make available different types of
CallServicebecause not all services require all the permissions thatCallServicerequires.For example if you are having an app only as a
livestreamguest you don't needphoneCallservice type, but rathermediaPlayback. Then you can remove the unnecessary permission in the manifest with, for example: