Skip to content

Conversation

@liviu-timar
Copy link
Contributor

@liviu-timar liviu-timar commented Sep 6, 2024

🎯 Goal

Fix reported bug:

Selecting a device id seems to break if the device id isn't the front facing camera. The VideoRenderer does not show any video until I change the camera and disable and reenable it.

🛠 Implementation details

Refactor the select, flip and setup methods in MediaManager.

🧪 Testing

  • Add call.camera.select("0") (use the main back camera ID) to the call lobby screen.
  • Start the call.
  • Switch between back/front cameras.

🎉 GIF

@liviu-timar liviu-timar marked this pull request as ready for review September 6, 2024 10:16
@liviu-timar liviu-timar requested a review from a team as a code owner September 6, 2024 10:16
@liviu-timar liviu-timar force-pushed the PBE-5816-fix-camera-selection-bug branch from 330ab6a to fe17ffd Compare September 6, 2024 10:16
@aleksandar-apostolov aleksandar-apostolov merged commit 59d62fa into develop Sep 9, 2024
@aleksandar-apostolov aleksandar-apostolov deleted the PBE-5816-fix-camera-selection-bug branch September 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants