Skip to content

Conversation

@liviu-timar
Copy link
Contributor

@liviu-timar liviu-timar commented Mar 24, 2025

🎯 Goal

We need to show a fallback content for the screensharing renderer while the track is loading or is not available. Now we show a track failed to load error.

🛠 Implementation details

  • Added a new fallback parameter, starting from ParticipantsLayout and down the tree. ParticipantsLayout is used in CallContent and can be customized in the videoContent parameter.
  • The default for the fallback content is the user avatar.

🎨 UI Changes

Before After
Screen_recording_20250409_104934 Screen_recording_20250409_104518

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.21 MB 11.21 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.66 MB 5.66 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.83 MB 5.84 MB 0.02 MB 🟢

@liviu-timar liviu-timar changed the title Add screen sharing fallback and avatar default Add screen sharing fallback and avatar default in SDK components Mar 24, 2025
@aleksandar-apostolov
Copy link
Contributor

Why is this still a draft?

@liviu-timar liviu-timar requested a review from Copilot April 8, 2025 06:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • stream-video-android-ui-compose/api/stream-video-android-ui-compose.api: Language not supported
Comments suppressed due to low confidence (1)

stream-video-android-ui-compose/src/main/kotlin/io/getstream/video/android/compose/ui/components/call/renderer/internal/ScreenShareVideoRenderer.kt:59

  • [nitpick] Consider using a consistent naming convention for the fallback content parameter across all screen sharing renderers. In some files it is named 'fallbackContent' while in others it is 'screenSharingFallbackContent'.
fallbackContent: @Composable (ScreenSharingSession) -> Unit = {

@liviu-timar liviu-timar marked this pull request as ready for review April 9, 2025 07:54
@liviu-timar liviu-timar requested a review from a team as a code owner April 9, 2025 07:54
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
37.5% Coverage on New Code (required ≥ 80%)
28.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 90be017 into develop Apr 14, 2025
9 of 10 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the screen-sharing-fallback branch April 14, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants