-
Notifications
You must be signed in to change notification settings - Fork 56
Add screen sharing fallback and avatar default in SDK components #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SDK Size Comparison 📏
|
|
Why is this still a draft? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- stream-video-android-ui-compose/api/stream-video-android-ui-compose.api: Language not supported
Comments suppressed due to low confidence (1)
stream-video-android-ui-compose/src/main/kotlin/io/getstream/video/android/compose/ui/components/call/renderer/internal/ScreenShareVideoRenderer.kt:59
- [nitpick] Consider using a consistent naming convention for the fallback content parameter across all screen sharing renderers. In some files it is named 'fallbackContent' while in others it is 'screenSharingFallbackContent'.
fallbackContent: @Composable (ScreenSharingSession) -> Unit = {
|


🎯 Goal
We need to show a fallback content for the screensharing renderer while the track is loading or is not available. Now we show a
track failed to loaderror.🛠 Implementation details
ParticipantsLayoutand down the tree.ParticipantsLayoutis used inCallContentand can be customized in thevideoContentparameter.🎨 UI Changes