-
Notifications
You must be signed in to change notification settings - Fork 56
[AND-429] Read call ID from launch intent extra #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SDK Size Comparison 📏
|
testableapple
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Just a quick question, do we need these dependencies in DemoApp and these sample tests? I have a local branch with the testing infra setup that will conflict with these changes.
|
@liviu-timar, could we also add an option to pass the user id/name via intent? |
@testableapple You don't need the changes from Maybe it's best to move them to a different PR. 🤔
I'll check and create a different PR if feasible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (1)
- demo-app/build.gradle.kts: Language not supported
|
Hey @liviu-timar, just tested the new callId argument, works like a charm! QQ, could we implement only the changes under |
This reverts commit 26e4959.
testableapple
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Done, can you do a quick test again? |
🎯 Goal
🛠 Implementation details
io.getstream.video.android.demoapp.CALL_ID:Future improvements:
🧪 Testing
-e io.getstream.video.android.demoapp.CALL_ID test-call-1234🎉 GIF