-
Notifications
You must be signed in to change notification settings - Fork 56
Use Android CI from common workflows #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughGitHub Actions workflows are modernized and consolidated: the Android CI pipeline migrates from multiple local jobs to a single external workflow delegation, while other workflows update runner environments from Ubuntu 22.04 to 24.04 and upgrade GitHub Actions versions for improved compatibility and security. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
2a26070 to
2aa6433
Compare
2aa6433 to
418bd8f
Compare
8c25d40 to
2234e86
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release-docs.yaml (1)
15-15: Inconsistent checkout action version across workflows.This workflow uses
actions/checkout@v3.1.0while other workflows in this PR update toactions/checkout@v4. Consider updating for consistency.🔎 Proposed update
- uses: actions/checkout@v3.1.0 + uses: actions/checkout@v4
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.github/workflows/android.yml.github/workflows/app-distribute.yml.github/workflows/internal-app-distribute.yml.github/workflows/release-docs.yaml
🔇 Additional comments (5)
.github/workflows/app-distribute.yml (1)
12-14: LGTM.Runner and checkout action updates align with the CI modernization across the PR.
.github/workflows/release-docs.yaml (2)
12-12: LGTM.Runner update to ubuntu-24.04 aligns with other workflows in this PR.
22-22: LGTM.Updating peaceiris/actions-gh-pages to v4 is a good modernization.
.github/workflows/android.yml (1)
20-22: External workflow version v0.6.0 is current and appropriate for this delegation.The v0.6.0 tag exists and is the latest release (published December 23, 2025). Notably, the release notes confirm this version specifically includes "Create shared Android CI workflow," which directly validates the purpose of this change. The repository shows consistent versioning history (v0.1.0 through v0.6.0) with no breaking changes noted in the changelog for this release. Verify that all required secrets are properly consumed by the external workflow through testing before merging.
.github/workflows/internal-app-distribute.yml (1)
20-22: Consider stability trade-offs before adopting ubuntu-24.04.The
actions/checkout@v4update is compatible with ubuntu-24.04; however, GitHub's runner-images reports documented stability issues with the ubuntu-24.04 image (Jan 2025–present): slower CI run times vs. ubuntu-22.04, intermittent OOM failures (exit 137), and capacity/queueing delays on public repos. This workflow does not use Docker/QEMU (where the worst issues occur), so it should function, but performance degradation and potential transient failures are possible. Weigh the modernization benefit against reliability risk, or monitor build times and failures closely if adopting ubuntu-24.04.



Goal
AND-781: Unify CI Across SDKs
We now have a CI workflow with common steps, so we're using that
Implementation
Use shared CI workflow
🎨 UI Changes
None
Testing
The expected pipeline steps should be run
☑️Contributor Checklist
General
developbranchCode & documentation
stream-video-examples)☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.