Prevent ringing state updates after RingingState.Timeout

[rahul-lohra]

Goal

Prevent updating ringing state after reaching RingingState.Timeout

Implementation

Prevent updating ringing state after reaching RingingState.Timeout

🎨 UI Changes

None

Testing

1. Login with User A on both web and Android.
2. Initiate a call from User B to User A.
3. Accept the call on the web platform — Android should transition Ringing state RingingState.Timeout to and render the main screen.
4. Check for logs with tag RingingState to verify Ringing state transitions

Summary by CodeRabbit

• Bug Fixes
  • Improved call state handling for timeout and rejection scenarios to prevent unnecessary state recalculations, ensuring more reliable call management.

[github-actions]

PR checklist ✅

All required conditions are satisfied:

• Title length is OK (or ignored by label).
• At least one pr: label exists.
• Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

[coderabbitai]

Walkthrough

The updateRingingState function in CallState.kt now early-returns when the ringing state is either TimeoutNoAnswer or RejectedByAll, expanding the previous single-condition early-exit logic to handle both terminal states uniformly.

Changes

Cohort / File(s)	Summary
Call State Logic stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt	Modified updateRingingState early-return condition to check for both TimeoutNoAnswer and RejectedByAll ringing states instead of RejectedByAll alone.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Poem

🐰 A call rings out, but time runs thin,
When answers don't come in,
Or all have said their "no" with pride,
The state now knows to step aside,
Two paths converge, one quiet end!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is largely incomplete, missing critical sections like Implementation details, Testing clarity, and Contributor/Reviewer checklists.	Expand the Implementation section with code details, clarify Testing steps (step 3 appears malformed), and complete the checklist sections with relevant items.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change—preventing ringing state updates after timeout.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/rahullohra/stop-updating-ringingstate-after-timeout-no-answer

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

[coderabbitai]

🧹 Nitpick comments (1)

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt (1)

1262-1268: Logic is correct; consider removing the empty else branch.

The early-return for both terminal states (TimeoutNoAnswer and RejectedByAll) is appropriate to prevent further ringing state updates after these final states are reached.

Since this is a when statement (not an expression requiring exhaustiveness), the else -> {} branch is unnecessary and can be removed for cleaner code.

,

🧹 Optional cleanup

-        when (ringingState.value) {
-            RingingState.TimeoutNoAnswer, RingingState.RejectedByAll -> {
-                return
-            }
-
-            else -> {}
-        }
+        if (ringingState.value == RingingState.TimeoutNoAnswer ||
+            ringingState.value == RingingState.RejectedByAll
+        ) {
+            return
+        }

Alternatively, keep when but drop the empty branch:

         when (ringingState.value) {
             RingingState.TimeoutNoAnswer, RingingState.RejectedByAll -> {
                 return
             }
-
-            else -> {}
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt`
around lines 1262 - 1268, The when block checking ringingState
(RingingState.TimeoutNoAnswer, RingingState.RejectedByAll) has an unnecessary
empty else branch; remove the else -> {} entirely from the when that guards
ringingState.value (in CallState.kt) so the early-return branches remain and the
when is simplified to only handle those terminal states.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt`:
- Around line 1262-1268: The when block checking ringingState
(RingingState.TimeoutNoAnswer, RingingState.RejectedByAll) has an unnecessary
empty else branch; remove the else -> {} entirely from the when that guards
ringingState.value (in CallState.kt) so the early-return branches remain and the
when is simplified to only handle those terminal states.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c5b9bff4-8b02-4924-99f6-abbb15aa2f8f

📥 Commits

Reviewing files that changed from the base of the PR and between 9128cd3 and b54e1ff.

📒 Files selected for processing (1)

• stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt

[github-actions]

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-video-android-core	12.00 MB	12.00 MB	0.00 MB	🟢
stream-video-android-ui-xml	5.68 MB	5.68 MB	0.00 MB	🟢
stream-video-android-ui-compose	6.27 MB	6.27 MB	0.00 MB	🟢

[sonarqubecloud]

Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[stream-public-bot]

🚀 Available in v1.21.0