Skip to content

Add videoPreviewModifier slot to CallLobby#1733

Merged
aleksandar-apostolov merged 1 commit into
developfrom
feature/call-lobby-video-preview-modifier
Jun 23, 2026
Merged

Add videoPreviewModifier slot to CallLobby#1733
aleksandar-apostolov merged 1 commit into
developfrom
feature/call-lobby-video-preview-modifier

Conversation

@aleksandar-apostolov

@aleksandar-apostolov aleksandar-apostolov commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Goal

Closes AND-1253. CallLobby hardcoded the preview Box to responsiveHeight + fillMaxWidth + RoundedCornerShape(12.dp) with no override. iOS sizes via the parent's GeometryReader, React via className — Android was the outlier.

Implementation

Add videoPreviewModifier: Modifier to CallLobby. Default preserves the previous chain via a private defaultVideoPreviewModifier() helper, so existing callers see no change.

CallLobby(
    call = call,
    videoPreviewModifier = Modifier
        .height(360.dp)
        .fillMaxWidth()
        .clip(RoundedCornerShape(24.dp)),
)

Testing

spotlessApply, apiDump, compileDebugKotlin, and CallLobbyTest paparazzi snapshot all pass locally.

☑️Contributor Checklist

General

  • PR targets the `develop` branch

Code & documentation

  • Changelog is updated with client-facing changes

The lobby video preview Box was hardcoded to a responsive height
(180/280/200dp by screen size and orientation), fillMaxWidth, and a 12dp
rounded corner clip with no way to override size or shape. iOS sizes the
preview via the parent's GeometryReader; React drives size via
className on VideoPreview. Android was the outlier.

Add a videoPreviewModifier parameter so callers can override the box
modifier directly. The default preserves the previous responsive height,
full width, and 12dp clip, so existing callers see no change.
@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner June 23, 2026 08:30
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@aleksandar-apostolov aleksandar-apostolov added the pr:new-feature Adds new functionality label Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

CallLobby gains a new videoPreviewModifier parameter (Modifier) with a default provided by the private defaultVideoPreviewModifier() helper, which applies responsive height, full width, and 12dp rounded clipping. The preview Box now uses this parameter instead of a locally constructed modifier. The public API signature and changelog are updated accordingly.

Changes

CallLobby videoPreviewModifier

Layer / File(s) Summary
videoPreviewModifier parameter, default helper, and API
stream-video-android-ui-compose/src/main/kotlin/io/getstream/video/android/compose/ui/components/call/lobby/CallLobby.kt, stream-video-android-ui-compose/api/stream-video-android-ui-compose.api, CHANGELOG.md
Adds videoPreviewModifier: Modifier = defaultVideoPreviewModifier() to CallLobby's signature, replaces the inline boxModifier in the preview Box with it, introduces the private defaultVideoPreviewModifier() composable computing responsive height and rounded corner clipping, updates KDoc, reflects the inserted Modifier parameter in the public API file, and adds the changelog entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

pr:new-feature

Suggested reviewers

  • rahul-lohra

Poem

🐇 A modifier hops into the lobby today,
With rounded corners shaped just the right way.
Default or custom, your preview box bends,
Responsive and clipped from start to ends.
The rabbit signs off — what a fine API! 🎨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a videoPreviewModifier parameter to CallLobby for customization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR description covers Goal, Implementation with code example, and Testing sections. Most required template sections are present and properly filled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/call-lobby-video-preview-modifier

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aleksandar-apostolov aleksandar-apostolov added pr:improvement Enhances an existing feature or code and removed pr:new-feature Adds new functionality labels Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.27 MB 12.27 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.20 MB 6.20 MB 0.00 MB 🟢

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@aleksandar-apostolov aleksandar-apostolov merged commit 8754b29 into develop Jun 23, 2026
23 of 30 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/call-lobby-video-preview-modifier branch June 23, 2026 10:39
@stream-public-bot stream-public-bot added the released Included in a release label Jun 23, 2026
@stream-public-bot

Copy link
Copy Markdown
Collaborator

🚀 Available in v1.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Enhances an existing feature or code released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants