Add videoPreviewModifier slot to CallLobby#1733
Conversation
The lobby video preview Box was hardcoded to a responsive height (180/280/200dp by screen size and orientation), fillMaxWidth, and a 12dp rounded corner clip with no way to override size or shape. iOS sizes the preview via the parent's GeometryReader; React drives size via className on VideoPreview. Android was the outlier. Add a videoPreviewModifier parameter so callers can override the box modifier directly. The default preserves the previous responsive height, full width, and 12dp clip, so existing callers see no change.
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Walkthrough
ChangesCallLobby videoPreviewModifier
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SDK Size Comparison 📏
|
|
|
🚀 Available in v1.28.0 |




Goal
Closes AND-1253.
CallLobbyhardcoded the preview Box toresponsiveHeight+fillMaxWidth+RoundedCornerShape(12.dp)with no override. iOS sizes via the parent'sGeometryReader, React viaclassName— Android was the outlier.Implementation
Add
videoPreviewModifier: ModifiertoCallLobby. Default preserves the previous chain via a privatedefaultVideoPreviewModifier()helper, so existing callers see no change.Testing
spotlessApply,apiDump,compileDebugKotlin, andCallLobbyTestpaparazzi snapshot all pass locally.☑️Contributor Checklist
General
Code & documentation