Fix: ask for push permission in dogfooding app in QR code flow#724
Merged
DanielNovak merged 4 commits intodevelopfrom Aug 4, 2023
Merged
Fix: ask for push permission in dogfooding app in QR code flow#724DanielNovak merged 4 commits intodevelopfrom
DanielNovak merged 4 commits intodevelopfrom
Conversation
DanielNovak
force-pushed
the
fix_permissions
branch
2 times, most recently
from
2b6faad to
dc8d27c
Compare
DanielNovak
commented
Aug 3, 2023
dogfooding/src/main/kotlin/io/getstream/video/android/DeeplinkingActivity.kt
Show resolved
Hide resolved
DanielNovak
force-pushed
the
fix_permissions
branch
from
dc8d27c to
ab8bdae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meeting can be opened the first time directly from QR code or automatically from Google Play referrer. In this case we jump directly to the meeting - leaving no time to ask for push notification permission. As a quick solution we can wait in the
DeeplinkingActivityuntil the permission is given and the proceed. Not waiting causes multiple permission requests to be fired with random / wrong behaviour.This does not impact normal usage once the app has been launched at least once before and we have the permissions.