Remove participant tracks in ParticipantLeftEvent#765
Merged
DanielNovak merged 2 commits intodevelopfrom Aug 16, 2023
Merged
Conversation
DanielNovak
force-pushed
the
fix_participant_left
branch
from
d512d27 to
3bb465d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/GetStream/android-video-issues-tracking/issues/8
We need to remove any tracks related to the participant once he leaves. Currently the tracks stay there and are never cleared and can cause crashes if the same participant rejoins the call and
TrackPublishedEventis received and then the old tracks associated with the Participant are updated => crash.