Fix initial microphone state (don't publish if muted)#771
Merged
DanielNovak merged 2 commits intodevelopfrom Aug 17, 2023
Merged
Fix initial microphone state (don't publish if muted)#771DanielNovak merged 2 commits intodevelopfrom
DanielNovak merged 2 commits intodevelopfrom
Conversation
DanielNovak
force-pushed
the
fix_audio_mic
branch
from
3924faf to
596cb09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/GetStream/android-video-issues-tracking/issues/18
We need to only publish the audio track if the microphone is unmuted. Currently we publish it and then we mute it immediately - but that doesn't work correctly because the mute request is faster than the track creation (it happens before
TrackPublishedEvent.This is useful in following scenario:
We would previously create the audio track and then mute it after that. This "worked" - but other participants would see you as "unmuted" even though locally the microphone was disabled, but the mute request (
RtcSession.setMuteState()) was called too soon and didn't have an effect.This change now also allows us to remove the "hotfix" we had in the
TrackPublishedEventfor handling the local participant audio and video state.