Merged
Conversation
…uce clutter in portrait and landscape renderer
…participant_view_redesign
…ParticipantGrid to ParticipantLayout and add layout types
…ate the layout on choice
skydoves
reviewed
Oct 30, 2023
Contributor
skydoves
left a comment
skydoves
left a comment
There was a problem hiding this comment.
overall looks really great. Nicely done! I left several comments especially for docs.
.../kotlin/io/getstream/video/android/compose/ui/components/call/renderer/ParticipantsLayout.kt
Show resolved
Hide resolved
...tstream/video/android/compose/ui/components/call/renderer/internal/SpotlightVideorenderer.kt
Outdated
Show resolved
Hide resolved
...tlin/io/getstream/video/android/compose/ui/components/call/renderer/ParticipantsSpotlight.kt
Show resolved
Hide resolved
...ain/kotlin/io/getstream/video/android/compose/ui/components/call/renderer/internal/Common.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/io/getstream/video/android/compose/ui/components/call/renderer/internal/Common.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Also updated minor design feedback into the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a spotlight view.
Allow for the participants layout to switch between layout types.
Three layout types added
Dynamic - if there are pinned participants its spotlight, grid otherwise.
Spotlight - fixed spotlight view, showing the dominant speaker, if there is no dominant speaker, the first one is selected
Grid - As before.
Layout chooser - added in dogfodding invoked via leadingCallContent icon which pops up a dialog to choose the layout.
Additionally modify padding according to the design