Skip to content

Add legacy URL support for demo app deeplinking#950

Merged
liviu-timar merged 7 commits intodevelopfrom
deeplinking-improvements
Dec 22, 2023
Merged

Add legacy URL support for demo app deeplinking#950
liviu-timar merged 7 commits intodevelopfrom
deeplinking-improvements

Conversation

@liviu-timar
Copy link
Contributor

@liviu-timar liviu-timar commented Nov 29, 2023

🎯 Goal

We should match both stream-calls-dogfood.vercel.app and pronto.getstream.io for the deep links as stream-calls-dogfood is used in some older recurring meeting series in Google Calendar.

Next step is to support the following case:

The idea is to not have “staging” / “production” anymore as both Pronto and Demo will eventually run on Production environments by default as we want to have production-level stability for internal meetings too

Both dogfooding and production flavors should handle all hosts? See issue here.

🛠 Implementation details

  • Added new "legacy" host in .env.properties:
DOGFOODING_RES_CONFIG_DEEPLINKING_HOST=pronto.getstream.io
DOGFOODING_RES_CONFIG_DEEPLINKING_HOST_LEGACY=stream-calls-dogfood.vercel.app
DOGFOODING_RES_CONFIG_DEEPLINKING_PATH_PREFIX=/
PRODUCTION_RES_CONFIG_DEEPLINKING_HOST=getstream.io
PRODUCTION_RES_CONFIG_DEEPLINKING_HOST_LEGACY=
PRODUCTION_RES_CONFIG_DEEPLINKING_PATH_PREFIX=/video/demos/

Also added new line in env.properties.sample and readme.md.

  • Added new intent-filter for DeeplinkingActivity with legacy host. For production, the legacy host is empty and will not match any URIs.

  • Changed the label that the user sees when the app chooser appears after scanning a code, from "call_link" to "Join video call" (see below).

🎨 UI Changes

Screenshot 2023-11-30 at 10 41 12

🧪 Testing

@liviu-timar liviu-timar marked this pull request as ready for review November 30, 2023 09:05
@liviu-timar liviu-timar requested a review from a team as a code owner November 30, 2023 09:05
@liviu-timar liviu-timar force-pushed the deeplinking-improvements branch from 7d524da to f7e7147 Compare November 30, 2023 09:24
@liviu-timar liviu-timar changed the title Add legacy vercel host support for demo app deeplinking Add legacy host support for demo app deeplinking Nov 30, 2023
@liviu-timar liviu-timar changed the title Add legacy host support for demo app deeplinking Add legacy URL support for demo app deeplinking Nov 30, 2023
Copy link
Contributor

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@liviu-timar liviu-timar force-pushed the deeplinking-improvements branch from f7e7147 to 2cf399a Compare December 22, 2023 11:47
@liviu-timar liviu-timar merged commit 3a4821f into develop Dec 22, 2023
@liviu-timar liviu-timar deleted the deeplinking-improvements branch December 22, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants