Add legacy URL support for demo app deeplinking#950
Merged
liviu-timar merged 7 commits intodevelopfrom Dec 22, 2023
Merged
Conversation
7d524da to
f7e7147
Compare
f7e7147 to
2cf399a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
We should match both
stream-calls-dogfood.vercel.appandpronto.getstream.iofor the deep links asstream-calls-dogfoodis used in some older recurring meeting series in Google Calendar.Next step is to support the following case:
Both dogfooding and production flavors should handle all hosts? See issue here.
🛠 Implementation details
Also added new line in env.properties.sample and readme.md.
Added new
intent-filterforDeeplinkingActivitywith legacy host. For production, the legacy host is empty and will not match any URIs.Changed the label that the user sees when the app chooser appears after scanning a code, from "call_link" to "Join video call" (see below).
🎨 UI Changes
🧪 Testing