Improve SDK BitmapVideoFilter memory usage#969
Merged
liviu-timar merged 5 commits intodevelopfrom Dec 19, 2023
Merged
Conversation
360-520 MB memory usage Needs testing
DanielNovak
approved these changes
Dec 19, 2023
Contributor
Author
|
Same call, original blur (without PorterDuff compositing): both phones in call for over 2h. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
When using
BitmapVideoFilter, memory usage increases rapidly and the client app crashes. Memory usage should be stable, GC should be able to keep up.🛠 Implementation details
Refactored
YuvFrame:Released
yuvBufferinFilterVideoProcessor.🧠 Memory Usage
🧪 Testing
☑️Contributor Checklist
General
developbranchCode & documentation
☑️Reviewer Checklist
🎉 GIF