fix(video_renderer): disable mirroring for rendering local back camera stream #628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Improve user experience by ensuring the video orientation matches user expectations. The change prevents mirroring for local back camera video streams, making the display more intuitive, especially in contexts where mirroring could confuse or degrade the viewing experience.
🛠 Implementation details
Modified the
StreamVideoRendererclass to detect if a video stream is local and from the back camera. If these conditions are met, the video is not mirrored. This involved checking thevideoTrack'smediaConstraints.facingModeagainstFacingMode.environmentto identify back camera usage and adjusting themirrorvariable accordingly.🎨 UI Changes
🧪 Testing
This change targets the video rendering behavior, requiring live testing with video streams from both front and back cameras to validate the implementation.
☑️ Contributor Checklist
☑️ Reviewer Checklist