Skip to content

Conversation

@kanat
Copy link
Contributor

@kanat kanat commented Aug 9, 2024

🎯 Goal

Since we use RECEIVER_NOT_EXPORTED flag while registering the BroadcastReceiver, we also have to set packageName to Intent itself to let OS know that actions are being sent internally in the app.

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@kanat kanat requested a review from a team as a code owner August 9, 2024 20:06
Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brazol Brazol merged commit 9896f16 into main Aug 15, 2024
@Brazol Brazol deleted the android-notification branch August 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants