Allow Lobby components to use a custom instance of StreamVideo #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This allows the
StreamLobbyViewandStreamLobbyVideoto use a custom instance ofStreamVideo.This ensures that apps which initialize Stream using
StreamVideo.createcan still use these components.Resolves one of the suggestions in #741
🛠 Implementation details
Add an optional
streamVideoparameters to the constructors ofStreamLobbyViewandStreamLobbyVideo. If this parameter is omitted, the widgets will fall back toStreamVideo.instance.🎨 UI Changes
Add relevant screenshots
Add relevant videos
🧪 Testing
Pass in a non-singleton instance of
StreamVideoto the two Lobby widgets and verify that they use the given instance. Also verify that the behaviour remains the same otherwise.☑️Contributor Checklist
General
☑️Reviewer Checklist