Skip to content

Conversation

@ptrbrynt
Copy link
Contributor

@ptrbrynt ptrbrynt commented Aug 22, 2024

🎯 Goal

This allows the StreamLobbyView and StreamLobbyVideo to use a custom instance of StreamVideo.

This ensures that apps which initialize Stream using StreamVideo.create can still use these components.

Resolves one of the suggestions in #741

🛠 Implementation details

Add an optional streamVideo parameters to the constructors of StreamLobbyView and StreamLobbyVideo. If this parameter is omitted, the widgets will fall back to StreamVideo.instance.

🎨 UI Changes

Add relevant screenshots

Before After
img img

Add relevant videos

Before After

🧪 Testing

Pass in a non-singleton instance of StreamVideo to the two Lobby widgets and verify that they use the given instance. Also verify that the behaviour remains the same otherwise.

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@ptrbrynt ptrbrynt requested a review from a team as a code owner August 22, 2024 12:58
@Brazol
Copy link
Contributor

Brazol commented Aug 27, 2024

Looks good, thanks for your contribution @ptrbrynt!

@Brazol Brazol merged commit 7a4722d into GetStream:main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants