Skip to content

fix: migrating to internet connection checker plus #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brazol merged 2 commits into from
Sep 25, 2024
Merged

fix: migrating to internet connection checker plus #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a929d28
migrating to internet connection checker plus
Brazol Sep 24, 2024
3b5113f
changelog
Brazol Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/stream_video/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## Unreleased

🐞 Fixed
* Migrated from `internet_connection_checker` to `internet_connection_checker_plus` due to [license issues](https://github.com/github/dmca/blob/master/2024/09/2024-09-04-internet-connection-checker-plus.md)

## 0.5.4

🐞 Fixed
Expand Down
10 changes: 5 additions & 5 deletions packages/stream_video/lib/src/call/call.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import 'dart:typed_data';
import 'package:collection/collection.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_webrtc/flutter_webrtc.dart';
import 'package:internet_connection_checker/internet_connection_checker.dart';
import 'package:meta/meta.dart';
import 'package:rxdart/rxdart.dart';
import 'package:internet_connection_checker_plus/internet_connection_checker_plus.dart';

import '../../stream_video.dart';
import '../../version.g.dart';
Expand Down Expand Up @@ -830,22 +830,22 @@ class Call {
tryFastReconnect = false;
});

final connectionStatus = await InternetConnectionChecker.createInstance(
final connectionStatus = await InternetConnection.createInstance(
checkInterval: const Duration(seconds: 1),
)
.onStatusChange
.firstWhere((status) => status == InternetConnectionStatus.connected)
.firstWhere((status) => status == InternetStatus.connected)
.timeout(
_reconnectTimeout,
onTimeout: () {
_logger.w(() => '[reconnect] timeout');

return InternetConnectionStatus.disconnected;
return InternetStatus.disconnected;
},
);

//no internet connection after _reconnectTimeout, leave the call
if (connectionStatus != InternetConnectionStatus.connected) {
if (connectionStatus != InternetStatus.connected) {
timer.cancel();
await leave();
return;
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_video/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies:
sdk: flutter
flutter_webrtc: ^0.11.7
http: ^1.1.0
internet_connection_checker: ^2.0.0
internet_connection_checker_plus: ^2.5.2
intl: ">=0.18.1 <=0.19.0"
jose: ^0.3.4
meta: ^1.9.1
Expand Down
5 changes: 5 additions & 0 deletions packages/stream_video_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## Unreleased

🐞 Fixed
* Migrated from `internet_connection_checker` to `internet_connection_checker_plus` due to [license issues](https://github.com/github/dmca/blob/master/2024/09/2024-09-04-internet-connection-checker-plus.md)

## 0.5.4

🐞 Fixed
Expand Down