Skip to content

Update code signing #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
testableapple merged 1 commit into from
Oct 29, 2024
Merged

Update code signing #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions dogfooding/ios/Runner.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = "";
DEVELOPMENT_TEAM = EHV7XZLAHA;
ENABLE_USER_SCRIPT_SANDBOXING = YES;
GCC_C_LANGUAGE_STANDARD = gnu17;
GENERATE_INFOPLIST_FILE = YES;
Expand Down Expand Up @@ -617,12 +617,10 @@
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
CODE_SIGN_ENTITLEMENTS = ScreenSharing/ScreenSharing.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = EHV7XZLAHA;
DEVELOPMENT_TEAM = EHV7XZLAHA;
ENABLE_USER_SCRIPT_SANDBOXING = YES;
GCC_C_LANGUAGE_STANDARD = gnu17;
GENERATE_INFOPLIST_FILE = YES;
Expand All @@ -640,8 +638,7 @@
MTL_FAST_MATH = YES;
PRODUCT_BUNDLE_IDENTIFIER = io.getstream.video.flutter.dogfooding.ScreenSharing;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore io.getstream.video.flutter.dogfooding.ScreenSharing";
PROVISIONING_PROFILE_SPECIFIER = "match AppStore io.getstream.video.flutter.dogfooding.ScreenSharing";
SKIP_INSTALL = YES;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_VERSION = 5.0;
Expand All @@ -662,11 +659,9 @@
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
CODE_SIGN_ENTITLEMENTS = ScreenSharing/ScreenSharing.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = EHV7XZLAHA;
DEVELOPMENT_TEAM = EHV7XZLAHA;
ENABLE_USER_SCRIPT_SANDBOXING = YES;
GCC_C_LANGUAGE_STANDARD = gnu17;
GENERATE_INFOPLIST_FILE = YES;
Expand All @@ -685,7 +680,6 @@
PRODUCT_BUNDLE_IDENTIFIER = io.getstream.video.flutter.dogfooding.ScreenSharing;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match Development io.getstream.video.flutter.dogfooding.ScreenSharing";
SKIP_INSTALL = YES;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_VERSION = 5.0;
Expand Down Expand Up @@ -811,7 +805,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)";
DEVELOPMENT_TEAM = "";
DEVELOPMENT_TEAM = EHV7XZLAHA;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = Runner/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Flutter Dogfooding";
Expand Down Expand Up @@ -839,12 +833,10 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)";
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = EHV7XZLAHA;
DEVELOPMENT_TEAM = EHV7XZLAHA;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = Runner/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Flutter Dogfooding";
Expand All @@ -856,8 +848,7 @@
MARKETING_VERSION = 1.0.0;
PRODUCT_BUNDLE_IDENTIFIER = io.getstream.video.flutter.dogfooding;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore io.getstream.video.flutter.dogfooding 1706028745";
PROVISIONING_PROFILE_SPECIFIER = "match AppStore io.getstream.video.flutter.dogfooding";
SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h";
SWIFT_VERSION = 5.0;
VERSIONING_SYSTEM = "apple-generic";
Expand Down
55 changes: 25 additions & 30 deletions dogfooding/ios/fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
default_platform :ios
import "../../Fastfile"
import '../../Fastfile'

default_platform(:ios)

before_all do
if is_ci
setup_ci()
end
setup_ci if is_ci
end

platform :ios do

lane :archive do |options|
method = options[:method]

Expand All @@ -19,7 +16,7 @@ platform :ios do
silent: true,
clean: true,
include_symbols: true,
output_directory: "./dist",
output_directory: './dist',
)
end

Expand All @@ -28,7 +25,6 @@ platform :ios do
fetch_dependencies
build_autogenerated_code


sign_enabled = options[:sign_enabled] || false
sign_param = sign_enabled ? '' : '--no-codesign'

Expand All @@ -41,10 +37,10 @@ platform :ios do
lane :build_and_deploy do
match(
api_key: appstore_api_key,
type: "appstore",
type: 'appstore',
app_identifier: [
"io.getstream.video.flutter.dogfooding",
"io.getstream.video.flutter.dogfooding.ScreenSharing",
'io.getstream.video.flutter.dogfooding',
'io.getstream.video.flutter.dogfooding.ScreenSharing',
],
readonly: is_ci,
force_for_new_devices: false,
Expand All @@ -53,45 +49,45 @@ platform :ios do
current_build_number = app_store_build_number(
api_key: appstore_api_key,
live: false,
app_identifier: "io.getstream.video.flutter.dogfooding",
username: ENV["FASTLANE_APPLE_ID"],
team_id: "EHV7XZLAHA",
platform: "ios",
app_identifier: 'io.getstream.video.flutter.dogfooding',
username: ENV['FASTLANE_APPLE_ID'],
team_id: 'EHV7XZLAHA',
platform: 'ios',
)

increment_build_number(build_number: current_build_number + 1)

build(sign_enabled: true)
archive(method: "app-store")
archive(method: 'app-store')

begin
upload_to_testflight(
api_key: appstore_api_key,
distribute_external: true,
notify_external_testers: true,
groups: ['Internal Testers', 'External Testers'],
changelog: "Lots of amazing new features to test out!",
changelog: 'Lots of amazing new features to test out!',
reject_build_waiting_for_review: false,
skip_waiting_for_build_processing: false,
)
rescue Exception => e
if e.message.include? "Another build is in review"
UI.important("Another build is already in beta review. Skipping beta review submission")
if e.message.include? 'Another build is in review'
UI.important('Another build is already in beta review. Skipping beta review submission')
else
UI.user_error!(e)
end
end
end

private_lane :appstore_api_key do
appstore_api_key ||= app_store_connect_api_key(
key_id: 'MT3PRT8TB7',
issuer_id: '69a6de96-0738-47e3-e053-5b8c7c11a4d1',
key_content: File.read(File.expand_path('~/.ssh/appstore_api_key')),
in_house: false
)
end
@appstore_api_key ||= app_store_connect_api_key(
key_id: 'MT3PRT8TB7',
issuer_id: '69a6de96-0738-47e3-e053-5b8c7c11a4d1',
key_content: ENV.fetch('APPSTORE_API_KEY', nil),
in_house: false
)
end

desc "If `readonly: true` (by default), installs all Certs and Profiles necessary for development and ad-hoc.\nIf `readonly: false`, recreates all Profiles necessary for development and ad-hoc, updates them locally and remotely."
desc "If `register_device: false` (by default), no device registration.\nIf `register_device: true`, will register a new device."
lane :match_me do |options|
Expand All @@ -102,7 +98,7 @@ platform :ios do
name: device_name,
udid: device_udid,
api_key: appstore_api_key,
)
)
options[:readonly] = false
end
app_identifiers = [
Expand All @@ -119,5 +115,4 @@ platform :ios do
)
end
end

end
end