chore(dogfooding): upgrade AGP to 8.8 #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renefloor
force-pushed
the
chore/dogfooding-agp-8
branch
from
bfef498 to
755176e
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Describe why we are making this change
The android dogfooding build doesn't compile anymore, because the record_android plugin doesn't work well with AGP 7. Upgrading to AGP 8 makes the app compile again and future proof.
🛠 Implementation details
Describe the implementation
This also contains a proguard file, because proguard behaves different on AGP 8.
🎨 UI Changes
No UI changes
🧪 Testing
Run the app on android, optionally with
flutter run --release☑️Contributor Checklist
General
☑️Reviewer Checklist