Skip to content

fix: adjusted disconnect codes mapping#2165

Merged
greenfrvr merged 1 commit intofeat/callkit-telecom-integrationfrom
fix/android-disconnect-reasons
Mar 17, 2026
Merged

fix: adjusted disconnect codes mapping#2165
greenfrvr merged 1 commit intofeat/callkit-telecom-integrationfrom
fix/android-disconnect-reasons

Conversation

@greenfrvr
Copy link
Contributor

💡 Overview

As per documentation Telecom API disconnect method accepts limited disconnect cause codes. This PR adjust disconnect reason codes mapping, so that only valid values can be passed to Telecom API disconnect method. Using codes outside that range causes a crash:

image

@greenfrvr greenfrvr requested a review from santhoshvai March 17, 2026 10:26
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2026

⚠️ No Changeset found

Latest commit: fba285c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89e9d3d9-a19d-4ee3-8eff-d5495130a107

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/android-disconnect-reasons
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greenfrvr greenfrvr requested a review from oliverlaz March 17, 2026 10:26
@greenfrvr greenfrvr merged commit 1ac2267 into feat/callkit-telecom-integration Mar 17, 2026
13 checks passed
@greenfrvr greenfrvr deleted the fix/android-disconnect-reasons branch March 17, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants