Skip to content

Conversation

ipavlidakis
Copy link
Contributor

@ipavlidakis ipavlidakis commented May 22, 2024

🎯 Goal

Use single instances for Call objects with the same cId. That helps ensuring that irregardless of the Call object creation point, actions performed to it will be synced across every observer.

📝 Summary

StreamVideo and Call internally use a thread-safe cache that ensures that only a single instance of Call object will exist for the same cId.

🧪 Manual Testing Notes

  • Regular join call flows should remain working.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label May 22, 2024
@ipavlidakis ipavlidakis self-assigned this May 22, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner May 22, 2024 09:50
@ipavlidakis ipavlidakis force-pushed the enhancement/call-caching branch from e5bb77f to 572d6a8 Compare May 22, 2024 11:22
@ipavlidakis ipavlidakis force-pushed the enhancement/call-caching branch from 572d6a8 to cd2a333 Compare May 22, 2024 13:44
@ipavlidakis ipavlidakis merged commit cbeb404 into main May 22, 2024
@ipavlidakis ipavlidakis deleted the enhancement/call-caching branch May 22, 2024 16:12
@ipavlidakis ipavlidakis mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants