[Fix]CallSettings not respected when create=false
#745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public Interface🚀 No changes affecting the public interface. |
Public Interface🚀 No changes affecting the public interface. |
SDK Size
|
|
martinmitrevski
approved these changes
Apr 4, 2025
ipavlidakis
deleted the
fix/callsettings-not-being-respected-when-not-creating-call
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-778/livestream-viewer-attempts-to-publish-audio-when-not-capability-exist
📝 Summary
This revision fixes an issue that only applying CallSettings (either the provided ones or from the dashboard) when the call was created and joined. The issue was discovered when testing with Livestream viewers who are only joining the call (not creating it).
☑️ Contributor Checklist