Skip to content

data(brand): enrich logo/website/founded_year from Wikidata#47

Merged
Seungpyo1007 merged 2 commits into
mainfrom
data/brand-wikidata
Jun 21, 2026
Merged

data(brand): enrich logo/website/founded_year from Wikidata#47
Seungpyo1007 merged 2 commits into
mainfrom
data/brand-wikidata

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

Summary

Enrich brand metadata from authoritative Wikidata (P154 logo, P856 website, P571 inception):

  • logo_url for 17 brands
  • website for 26 brands
  • founded_year for 21 brands

All values come from Wikidata entities filtered by a description guard (must read as a company/electronics/phone/tech entity), which correctly skips wrong-name collisions (Amoi→Indonesian village, Bird→surname, etc.). Gap-only: existing values (incl. the hand-verified founded_years from #46) are never overwritten. Matching site/public/v1/brands dump details refreshed.

Verification

  • python -m app.validate PASS
  • python TechEngine/integrity_check.py data --strict PASS
  • git diff --check origin/main...HEAD PASS
  • Logo URLs use the stable commons.wikimedia.org/wiki/Special:FilePath/<file> redirect. Local site build skipped (worktree without node_modules; build-safe metadata; TechEngine homepage validation builds).

Closes #1

Fill missing brand logo_url (17), website (23), founded_year (9) from authoritative Wikidata (P154/P856/P571). Description-guard skips wrong-entity name collisions; gap-only so #46's hand-verified founded_years are preserved.

Refs #1
@Seungpyo1007 Seungpyo1007 force-pushed the data/brand-wikidata branch from 0a10683 to 9a67ffc Compare June 21, 2026 20:17
@Seungpyo1007 Seungpyo1007 merged commit 7e7bc5a into main Jun 21, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jun 21, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 189 0 189 0 189 0.0%
soc 2104 58 2046 0 2104 2.8%
smartphone 90118 184 89934 0 90118 0.2%
tablet 3048 0 3048 0 3048 0.0%
watch 378 0 378 0 378 0.0%
pda 110 0 110 0 110 0.0%
gpu 2030 0 2030 0 2030 0.0%
cpu 3977 976 3001 0 3977 24.5%
all 101954 1218 100736 0 101954 1.2%

Warning

Tracked verified coverage is below 50% for brand 0.0% (0/189), tablet 0.0% (0/3048), watch 0.0% (0/378), pda 0.0% (0/110), gpu 0.0% (0/2030), smartphone 0.2% (184/90118), all 1.2% (1218/101954), soc 2.8% (58/2104), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Massive dataset rebuild: CPU + brand + GPU + smartphone + SoC (1989-2026)

2 participants