Skip to content

Mark more strings as translatable#270

Merged
mhall119 merged 1 commit intoGetTogetherComm:masterfrom
urbalazs:mark-for-translation
Feb 20, 2020
Merged

Mark more strings as translatable#270
mhall119 merged 1 commit intoGetTogetherComm:masterfrom
urbalazs:mark-for-translation

Conversation

@urbalazs
Copy link
Copy Markdown
Contributor

Hello @mhall119
I found some strings that are not marked as translatable. However there are more untranslated string, which I did find in the source:

  • On the start page: City
  • On the Edit Team page, the labels Description, About page, Category (and its options), City
  • On the Edit Event Detail page, the label Summary, the +Add rule and +Add date sections
  • On the Change Host page, the label Team

Can you please check, why do them not get translated?

@ghost
Copy link
Copy Markdown

ghost commented Feb 12, 2020

DeepCode's analysis on #68e490 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@mhall119 mhall119 merged commit c6912b4 into GetTogetherComm:master Feb 20, 2020
@mhall119
Copy link
Copy Markdown
Collaborator

For the ones you couldn't find, I created a new issue for fixing them and tracked down what needs to be changed to make them translatable: #271

@urbalazs urbalazs deleted the mark-for-translation branch January 2, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants