Multiple upgrades to get the system working locally with docker and Django 3#310
Multiple upgrades to get the system working locally with docker and Django 3#310mhall119 merged 6 commits intoGetTogetherComm:masterfrom
Conversation
The repo switched from "master" to "main" branch naming.
Update isort version for pre-commit.
| language_version: python3 | ||
| - repo: https://github.com/pre-commit/mirrors-isort | ||
| rev: "master" # Use the revision sha / tag you want to point at | ||
| rev: "main" # Use the revision sha / tag you want to point at |
There was a problem hiding this comment.
project switched to main branch naming
| @@ -1,27 +1,16 @@ | |||
| FROM python:3-alpine as builder | |||
| FROM python:3.9-slim | |||
There was a problem hiding this comment.
Alpine doesn't always play well with Python. See https://pythonspeed.com/articles/alpine-docker-python/
|
|
||
| RUN apk add --no-cache zlib-dev build-base python-dev jpeg-dev | ||
| RUN pip install virtualenv | ||
| RUN virtualenv venv |
There was a problem hiding this comment.
No need to use venvs within Docker really.
| In order to make it easier to create Places and Teams without having to manually | ||
| enter records for Country, SPR (State/Province/Region) and City, you can preload | ||
| them using data files from <http://download.geonames.org/export/dump/> | ||
| them using data files from <https://download.geonames.org/export/dump/> |
There was a problem hiding this comment.
Many browsers will prefer https over http.
| - SECRET_KEY=xxxxx | ||
| - ALLOWED_HOSTS=localhost,127.0.0.1 | ||
| volumes: | ||
| - ./:/home/python No newline at end of file |
There was a problem hiding this comment.
Hot reload of changes without rebuilding the docker image.
| <table> | ||
| {{ event_form }} | ||
| {{ event_form }} | ||
| {{ event_form.media }} |
There was a problem hiding this comment.
Needed for some widgets like recurrence.
| "images": {"nav_logo": "img/logo_b_v1.png"}, | ||
| } | ||
|
|
||
| DEFAULT_AUTO_FIELD = "django.db.models.AutoField" |
There was a problem hiding this comment.
Needed in new Django to avoid warnings in runserver.
| views.show_team_events_by_slug, | ||
| name="show-team-events-by-slug", | ||
| ), | ||
| path('jsi18n.js', JavaScriptCatalog.as_view(packages=['recurrence']), name='jsi18n'), |
There was a problem hiding this comment.
Needed by django-recurrence to load pgettext.
| Django==2.0.12 | ||
| django-appconf==1.0.2 | ||
| Django==3.2.13 | ||
| django-appconf==1.0.5 |
There was a problem hiding this comment.
Upgrades to work with Django 3 that doesn't include six.
|
|
||
| class ResumeConfig(AppConfig): | ||
| name = "Resume" | ||
| name = "resume" |
There was a problem hiding this comment.
Failed in Django 3 because it tried to import a module Resume that does not exist.
mhall119
left a comment
There was a problem hiding this comment.
These all look good to me, thank you so much!
Update all needed packages to make the system work locally with modern Django 3.2.12 and docker.