Skip to content

Conversation

@marcelkooi
Copy link

Description

This PR adds a note about the license of the project and calling out that it prevents Sidecar from making the repository private.

Checklist

  • Any important design changes are documented in project's Markdown documentation

@sc-igor
Copy link

sc-igor bot commented Jan 27, 2020

Cannot find that Jira card, you either forgot to add one to the title or it does not exist

@marcelkooi marcelkooi requested review from AlekseiAQ and nHurD January 27, 2020 14:26
rmartz
rmartz previously approved these changes Jan 28, 2020
Copy link

@rmartz rmartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit about hyperlink conventions 👍

Co-Authored-By: Reed Martz <reed@getsidecar.com>
@marcelkooi marcelkooi merged commit 7c47e64 into master Jan 28, 2020
@marcelkooi marcelkooi deleted the add-license-notes branch January 28, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants