Skip to content

[FIX] update ItemType retrieval to use 'id'#105

Merged
Geuthur merged 3 commits intomasterfrom
fix-get
Mar 13, 2026
Merged

[FIX] update ItemType retrieval to use 'id'#105
Geuthur merged 3 commits intomasterfrom
fix-get

Conversation

@Geuthur
Copy link
Copy Markdown
Owner

@Geuthur Geuthur commented Mar 13, 2026

Description

Fixed

  • update ItemType retrieval to use 'id'

Type of Changes

Please select the type of changes made in this pull request:

  • Bug Fix (non-breaking change which fixes an Issue)
  • New Feature (non-breaking change)
  • Other (please specify):

Checklist

Please ensure the following before submitting your pull request:

  • I have read the contributing guidelines.
  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
killstats/helpers/killmail.py 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   67.37%   69.70%   +2.33%     
==========================================
  Files          30       30              
  Lines        1422     1422              
  Branches      137      137              
==========================================
+ Hits          958      991      +33     
+ Misses        429      387      -42     
- Partials       35       44       +9     
Files with missing lines Coverage Δ
killstats/managers/killboard_manager.py 56.25% <100.00%> (+16.67%) ⬆️
killstats/helpers/killmail.py 76.29% <0.00%> (+4.59%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Geuthur Geuthur merged commit ad2ba84 into master Mar 13, 2026
22 of 23 checks passed
@Geuthur Geuthur deleted the fix-get branch March 13, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Error importing Killmail - killmail_body.victim.ship_type_id TypeError: cannot unpack non-iterable int object

1 participant