Skip to content

[FIX] OpenAPI3 Killmails not serializable#72

Merged
Geuthur merged 1 commit intomasterfrom
fix-openapi3-nested-objects
Nov 15, 2025
Merged

[FIX] OpenAPI3 Killmails not serializable#72
Geuthur merged 1 commit intomasterfrom
fix-openapi3-nested-objects

Conversation

@Geuthur
Copy link
Copy Markdown
Owner

@Geuthur Geuthur commented Nov 15, 2025

Description

Please include a summary of the changes and the related issue number (if applicable).

Fixed

  • OpenAPI3 Killmails not serializable

Type of Changes

Please select the type of changes made in this pull request:

  • Bug Fix (non-breaking change which fixes an Issue)
  • New Feature (non-breaking change)
  • Other (please specify):

Checklist

Please ensure the following before submitting your pull request:

  • I have read the contributing guidelines.
  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
killstats/helpers/killmail.py 15.39% 11 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   54.93%   54.62%   -0.31%     
==========================================
  Files          26       26              
  Lines        1249     1258       +9     
  Branches      115      119       +4     
==========================================
+ Hits          686      687       +1     
- Misses        555      563       +8     
  Partials        8        8              
Files with missing lines Coverage Δ
killstats/helpers/killmail.py 38.74% <15.39%> (-0.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Geuthur Geuthur merged commit 3e30391 into master Nov 15, 2025
29 of 42 checks passed
@Geuthur Geuthur deleted the fix-openapi3-nested-objects branch November 15, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Internal Server Error when adding killmail manually via /killstats/add_killmail/

1 participant