Skip to content

[CHANGE] Replace django-eveuniverse with django-eveonline-sde#98

Merged
Geuthur merged 3 commits intomasterfrom
remove-eveuniverse
Mar 3, 2026
Merged

[CHANGE] Replace django-eveuniverse with django-eveonline-sde#98
Geuthur merged 3 commits intomasterfrom
remove-eveuniverse

Conversation

@Geuthur
Copy link
Copy Markdown
Owner

@Geuthur Geuthur commented Mar 3, 2026

Description

Warning

Please note that this release involves structural dependency changes.
To avoid any service disruptions, it is essential to read the update manual prior to performing the upgrade.

Update Instructions

After isntalling this version, you need to modify INSTALLED_APPS in your local.py

INSTALLED_APPS = [
    # other apps
    "eve_sde",  # only if it not already existing
    "killstats",
    # other apps?
]

# This line is right below the `INSTALLED_APPS` list, if not already exist!
INSTALLED_APPS = ["modeltranslation"] + INSTALLED_APPS

Add the following new task to ensure the SDE data is kept up to date.

if "eve_sde" in INSTALLED_APPS:
    # Run at 12:00 UTC each day
    CELERYBEAT_SCHEDULE["EVE SDE :: Check for SDE Updates"] = {
        "task": "eve_sde.tasks.check_for_sde_updates",
        "schedule": crontab(minute="0", hour="12"),
    }

Due to the new R2Z2 endpoints, we need to replace the existing Celery task. Therefore, add the following new task to ensure that the killmails continue to be updated

if "killstats" in INSTALLED_APPS:
    CELERYBEAT_SCHEDULE["Killstats :: Check for Killmails"] = {
        "task": "killstats.tasks.run_zkb_r2z2",
        "schedule": crontab(minute="*/1"),
    }

After running migrations, make sure to run the following commands to import the SDE data into your database.

python manage.py esde_load_sde
python manage.py killstats_migrate_eveentity

Restart your Auth via supervisor after running these commands

Added

  • django-eveonline-sde dependency

Changed

  • Replace django-eveuniverse with django-eveonline-sde
  • Migration to R2Z2 endpoints, as Redis will be removed on May 31
  • Updated Translations

Removed

  • allianceauth-app-utils dependency
  • django-eveuniverse dependency

Type of Changes

Please select the type of changes made in this pull request:

  • Bug Fix (non-breaking change which fixes an Issue)
  • New Feature (non-breaking change)
  • Other (please specify):

Checklist

Please ensure the following before submitting your pull request:

  • I have read the contributing guidelines.
  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • All new and existing tests passed.

@Geuthur Geuthur merged commit 39138d3 into master Mar 3, 2026
22 checks passed
@Geuthur Geuthur deleted the remove-eveuniverse branch March 3, 2026 18:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 45.56962% with 86 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
killstats/helpers/eveonline.py 22.23% 28 Missing ⚠️
killstats/managers/general_manager.py 31.58% 25 Missing and 1 partial ⚠️
killstats/models/general.py 64.00% 18 Missing ⚠️
killstats/helpers/killmail.py 37.50% 5 Missing ⚠️
killstats/managers/killboard_manager.py 33.34% 4 Missing ⚠️
killstats/api/killstats/api_helper.py 25.00% 3 Missing ⚠️
killstats/models/killboard.py 83.34% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   65.90%   63.97%   -1.92%     
==========================================
  Files          28       30       +2     
  Lines        1296     1421     +125     
  Branches      124      137      +13     
==========================================
+ Hits          854      909      +55     
- Misses        410      479      +69     
- Partials       32       33       +1     
Files with missing lines Coverage Δ
killstats/api/killstats/stats.py 40.91% <ø> (ø)
killstats/app_settings.py 100.00% <100.00%> (ø)
killstats/models/__init__.py 100.00% <100.00%> (ø)
killstats/models/killboard.py 95.59% <83.34%> (-2.82%) ⬇️
killstats/api/killstats/api_helper.py 14.93% <25.00%> (-0.22%) ⬇️
killstats/managers/killboard_manager.py 38.95% <33.34%> (ø)
killstats/helpers/killmail.py 71.70% <37.50%> (+1.15%) ⬆️
killstats/models/general.py 70.50% <64.00%> (-29.50%) ⬇️
killstats/managers/general_manager.py 31.58% <31.58%> (ø)
killstats/helpers/eveonline.py 22.23% <22.23%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant