Skip to content

Hotfix: TinyMCE dark mode#853

Merged
chrismaddalena merged 16 commits intomasterfrom
hotfix/tinymce-dark-mode
Mar 28, 2026
Merged

Hotfix: TinyMCE dark mode#853
chrismaddalena merged 16 commits intomasterfrom
hotfix/tinymce-dark-mode

Conversation

@chrismaddalena
Copy link
Copy Markdown
Collaborator

CHANGELOG

[6.2.10] - 27 March 2026

Changed

  • Updated TinyMCE to work better with Ghostwriter's dark mode using a new dark-mode skin

Fixed

  • Fixed TinyMCE editors not initiating correctly for the "Results" field on objectives when adding new forms
  • Fixed TinyMCE editors sometimes appearing with a very short height and needing to be resized

TinyMCE will now use a dark mode skin when dark mode is enabled. This also sets a min height and addresses some timing issues to fix TinyMCE editors sometimes appearing almost fully collapsed vertically and unusable until resized by the user.
Copilot AI review requested due to automatic review settings March 28, 2026 01:08
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8afedd8dea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a TinyMCE dark-mode experience by shipping a new GhostwriterDark skin/content CSS and updating TinyMCE initialization to select skin/content styles based on Ghostwriter’s theme, while also addressing editor initialization and sizing issues in dynamic formsets.

Changes:

  • Added TinyMCE GhostwriterDark UI/content skin assets.
  • Updated TinyMCE config to apply skin/content CSS per theme and to refresh layout/autoresize during init/content changes and when UI elements are revealed.
  • Improved dynamic formset TinyMCE initialization (notably objective “Results”) and updated version/changelog.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
ghostwriter/static/js/tinymce/skins/ui/GhostwriterDark/skin.shadowdom.min.css Adds dark UI skin CSS for Shadow DOM contexts.
ghostwriter/static/js/tinymce/skins/ui/GhostwriterDark/skin.mobile.min.css Adds dark UI skin CSS for mobile.
ghostwriter/static/js/tinymce/skins/ui/GhostwriterDark/skin.min.css Adds primary dark UI skin CSS.
ghostwriter/static/js/tinymce/skins/ui/GhostwriterDark/content.mobile.min.css Adds mobile content-related CSS for the dark UI skin bundle.
ghostwriter/static/js/tinymce/skins/ui/GhostwriterDark/content.min.css Adds content-related CSS for the dark UI skin bundle.
ghostwriter/static/js/tinymce/skins/ui/GhostwriterDark/content.inline.min.css Adds inline content-related CSS for the dark UI skin bundle.
ghostwriter/static/js/tinymce/skins/content/GhostwriterDark/content.min.css Adds dark-mode editor iframe content CSS (background/text/link styling).
ghostwriter/static/js/tinymce/config.js Selects skin/content CSS based on theme; adds layout refresh/autoresize scheduling and theme observation.
ghostwriter/static/css/wysiwyg_styles.css Adjusts placeholder styling used by TinyMCE content CSS.
ghostwriter/static/css/styles.css Adds app-level dark-mode overrides for TinyMCE UI elements.
ghostwriter/rolodex/templates/rolodex/project_form.html Refactors dynamic formset TinyMCE init to initialize all eligible textareas in the new form.
ghostwriter/rolodex/forms_project.py Treats objective result as rich text and adds a placeholder.
config/settings/base.py Bumps app version/date to 6.2.10 / 27 March 2026.
VERSION Bumps version/date to match release.
CHANGELOG.md Adds 6.2.10 entry describing dark-mode skin + TinyMCE init/height fixes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (379a856) to head (e3cf043).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         373      373           
  Lines       21518    21519    +1     
=======================================
+ Hits        19717    19718    +1     
  Misses       1801     1801           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated no new comments.

@chrismaddalena chrismaddalena merged commit 5d2d61f into master Mar 28, 2026
13 checks passed
@chrismaddalena chrismaddalena deleted the hotfix/tinymce-dark-mode branch March 28, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants