Fixed issue with source ID and groups that could assign wrong severity

[chrismaddalena]

Adjustment to fix cases where a BHE finding could be grouped incorrectly.

[Copilot]

Pull request overview

Fixes BloodHound Enterprise findings grouping so relationship findings are keyed consistently across sourceid/source_id variants and distinct source→target pairs are not merged, preventing incorrect severity rollups.

Changes:

• Added a _get_source_id() helper to normalize BloodHound field-name variants (sourceid vs source_id) and used it in severity calculation + principal entries.
• Updated enterprise finding grouping logic to dedupe principals by (source_id, target_id) instead of only target_id.
• Extended BloodHound client tests to cover the source_id variant and distinct source/target pairing behavior; added Severity fixtures needed by get_enterprise_findings().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
ghostwriter/shepherd/external/bloodhound/client.py	Normalizes source ID extraction and fixes grouping/deduping logic to avoid collapsing distinct relationship findings.
ghostwriter/shepherd/tests/test_bloodhound_client.py	Adds regression tests for source_id handling and ensures distinct principals are retained; seeds Severity rows required for output enrichment.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.19%. Comparing base (a328fd2) to head (79b8cbd).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
+ Coverage   92.82%   93.19%   +0.36%     
==========================================
  Files         393      393              
  Lines       24908    24937      +29     
==========================================
+ Hits        23122    23239     +117     
+ Misses       1786     1698      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.