🛡️ Sentinel: [CRITICAL] Fix SSRF in proxy endpoint#8
Conversation
🚨 Severity: CRITICAL 💡 Vulnerability: The `/api/proxy/` endpoint allowed users to request internal network resources (localhost, private IPs) leading to SSRF. 🎯 Impact: Attackers could access internal services, metadata services (cloud), or the proxy server itself. 🔧 Fix: Implemented `is_safe_url` to validate input URLs, resolving hostnames and blocking private/loopback IPs. Added timeouts to prevent DoS. Hardened error messages. ✅ Verification: Added `tests/test_ssrf.py` which confirms localhost requests are blocked (400) while external requests (google.com) succeed.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The
/api/proxy/endpoint allowed users to request internal network resources (localhost, private IPs) leading to SSRF.🎯 Impact: Attackers could access internal services, metadata services (cloud), or the proxy server itself.
🔧 Fix: Implemented
is_safe_urlto validate input URLs, resolving hostnames and blocking private/loopback IPs. Added timeouts to prevent DoS. Hardened error messages.✅ Verification: Added
tests/test_ssrf.pywhich confirms localhost requests are blocked (400) while external requests (google.com) succeed.PR created automatically by Jules for task 2155436756076202811 started by @GhostTypes