Smarter review loop with soft-pass and environment issue detection#3
Merged
Smarter review loop with soft-pass and environment issue detection#3
Conversation
…sue detection
Overhaul the engine's review/retry loop to prevent false review failures
and add pre-flight environment checks with actionable in-app fix prompts.
Review improvements:
- Update review prompt to distinguish "critical" (bugs, security, data
loss) from "suggestion" (style nits, nice-to-haves) severity
- Add ReviewOutput.has_critical_issues() to inspect structured issues
- Soft-pass after max retries when only non-critical suggestions remain
— task succeeds with review_warnings attached instead of hard-failing
- Increase max_retries from 2 to 4 (5 total attempts)
- Fix error formatting: replace Rust Debug {:?} with proper unwrap so
users no longer see raw Some("...") wrappers in error messages
Environment issue detection:
- Add git::preflight_check() that runs before each task and pattern-
matches known env errors (Xcode license, git not found, not a repo)
- Emit agent:environment-issue event with error, fixCommand, fixLabel
- Add run_terminal_command Tauri command that opens Terminal.app via
AppleScript to run interactive fix commands (e.g. sudo xcodebuild)
- Add persistent environmentIssueToast with "Fix in Terminal" button
- Mount useEnvironmentIssueListener in AppContent (not AppShell) so it
stays active across all routes including /settings
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…omments Swap out react-diff-view for @pierre/diffs, gaining Shiki-powered syntax highlighting, split/unified toggle, word-level inline change detection, and Shadow DOM rendering. - Remove react-diff-view and unidiff dependencies - Rewrite TaskDiffViewer around PatchDiff component from @pierre/diffs - Add line selection (enableLineSelection) for highlighting ranges - Add inline commenting via gutter utility — users click a line to leave a comment, which renders as an annotation bubble in the diff - Collect inline comments into structured markdown when submitting "Request Changes" feedback, so the agent gets file:line context - Show inline comment count badge in the feedback mode banner - Add v0.2.0 changelog entry covering the new diff viewer, inline comments, and the review loop / environment check improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent:environment-issueevent. The frontend shows a persistent toast with a "Fix in Terminal" button that opens Terminal.app with the appropriate fix command.Debugformatting ({:?}) with proper string unwrapping so users no longer see rawSome("...")wrappers in error messages.Test plan
Some("...")formatting