refactor(genesis): improve provision-usb.py and add CI/CD#55
Merged
refactor(genesis): improve provision-usb.py and add CI/CD#55
Conversation
Remove the vyos-build custom image pipeline in favor of manually installing VyOS from the official Stream ISO during genesis bootstrap. This simplifies the bootstrap process and eliminates the chicken-and-egg dependency where Tinkerbell needed VyOS networking but VyOS was supposed to be provisioned via Tinkerbell. Changes: - Remove build-vyos-image.sh script and gateway.toml flavor template - Remove packer-ssh.sops.yaml (was for vyos-build SSH injection) - Update bootstrap procedure Step 2 with manual VyOS install instructions - Remove Step 7 (VyOS via Tinkerbell) - now 14 steps total - Update architecture docs to reflect manual VyOS bootstrap - Update image-pipeline.md to remove vyos-build workflow section - Update integration testing to use official vyos/vyos:current container The VP6630 gateway is now bootstrapped manually before Tinkerbell is available. Post-install configuration management remains via Ansible. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The sed -i '' syntax is macOS-specific. On Linux (GNU sed), this causes the sed expression to be interpreted as a filename. Use a temp file approach instead for cross-platform compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use external VMX templates for better readability - Load ISO configuration dynamically from images.yaml - Replace subprocess.which with shutil.which - Add justfile for development automation - Add GitHub Workflow for CI verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the maintainability and reliability of the
provision-usb.pyscript and adds CI/CD verification.Changes
bootstrap/genesis/scripts/templates/to improve readability.subprocess.run(["which", ...])withshutil.whichfor cleaner tool detection.images/images.yaml(source of truth), preventing version mismatch.jsonimports and metadata handling for VMDK caching (part of separate user edits included here).bootstrap/genesis/justfileto standardizefmt,lint, andcheckcommands usinguv..github/workflows/genesis.ymlto enforce formatting and linting on PRs.Verification
just checklocally to verifyruffformatting and linting.--help.