feat(labctl): detect transform hook input changes in images sync #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transform hooks can now declare input files/globs that affect their output via the `inputs` field. When specified, changes to these files trigger a re-sync without needing --force. The effective checksum now incorporates a hash of all declared input files, ensuring that changes to transform dependencies (like talconfig.yaml for the talos-embed-config hook) are properly detected. Closes: HOM-30 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The VyOS test script was waiting for "migrate.*configure" in container logs, but this pattern doesn't appear in the VyOS Stream ISO. The script would always wait all 90 iterations (180 seconds) before continuing. Switch to using Docker's healthcheck status instead, which uses `systemctl is-system-running` and properly indicates when the container is ready. This reduces CI wait time by ~2-3 minutes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jmgilman
deleted the
joshuagilman/hom-30-labctl-images-sync-doesnt-detect-transform-hook-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
inputsfield to transform hooks in image manifest, allowing declaration of files/globs that affect the hook's outputResolves HOM-30
Test plan
EffectiveChecksumWithInputscovering all scenariosjust allpasses (lint, vet, tests)🤖 Generated with Claude Code