Skip to content

fix: replace bash-only ${name^^} with portable tr for zsh compatibility #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GingerGraham merged 3 commits into from
May 27, 2026
Merged

fix: replace bash-only ${name^^} with portable tr for zsh compatibility #116

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
903af08
fix: replace bash-only ${name^^} with portable tr for zsh compatibility
Jah-yee May 26, 2026
0567c4d
fix: split local declaration and assignment for lint compliance
Jah-yee May 26, 2026
b2b5f92
Merge branch 'main' into fix/zsh-uppercase
GingerGraham May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions logging.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,9 +769,10 @@ _parse_config_file() {

# Convert log level name to numeric value (internal)
_get_log_level_value() {
local level_name="$1"
local level_name
level_name="$(printf '%s' "$1" | tr '[:lower:]' '[:upper:]')"
local line_num="${2:-}"
case "${level_name^^}" in
case "${level_name}" in
"DEBUG")
echo "$LOG_LEVEL_DEBUG"
;;
Expand Down Expand Up @@ -1898,13 +1899,14 @@ log_to_journal() {
return 1
fi

local level_name="$1"
local level_name
level_name="$(printf '%s' "$1" | tr '[:lower:]' '[:upper:]')"
shift
local message="$*"

# Validate and normalise the level name to the canonical form used by _log_message
local canonical_level
case "${level_name^^}" in
case "${level_name}" in
DEBUG) canonical_level="DEBUG" ;;
INFO) canonical_level="INFO" ;;
NOTICE) canonical_level="NOTICE" ;;
Expand Down
Loading