Skip to content

Readded value converters for DbType#287

Merged
Giorgi merged 3 commits intoGiorgi:developfrom
maurice-freitag:features/dbtype
Aug 19, 2025
Merged

Readded value converters for DbType#287
Giorgi merged 3 commits intoGiorgi:developfrom
maurice-freitag:features/dbtype

Conversation

@maurice-freitag
Copy link
Contributor

fixes #285

@Giorgi
Copy link
Owner

Giorgi commented Aug 19, 2025

Thanks, can you add test(s)?

@maurice-freitag
Copy link
Contributor Author

Thanks, can you add test(s)?

Gladly :) I tried to test it directly but the converter is internal and I didn't want to mess with the project structure too much by adding InternalsVisibleTo to the project. Should I follow this approach or test it indirectly by using functions like I wrote in the issue?

@Giorgi
Copy link
Owner

Giorgi commented Aug 19, 2025

Just use the query from your issue and verify that it returns the expected result.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17067204830

Details

  • 48 of 71 (67.61%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 89.36%

Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET.Data/PreparedStatement/ClrToDuckDBConverter.cs 47 70 67.14%
Files with Coverage Reduction New Missed Lines %
DuckDB.NET.Data/PreparedStatement/ClrToDuckDBConverter.cs 1 86.1%
Totals Coverage Status
Change from base Build 16909927337: -0.6%
Covered Lines: 2136
Relevant Lines: 2360

💛 - Coveralls

@maurice-freitag maurice-freitag requested a review from Giorgi August 19, 2025 13:16
@Giorgi Giorgi merged commit a632ebd into Giorgi:develop Aug 19, 2025
25 of 35 checks passed
@maurice-freitag maurice-freitag deleted the features/dbtype branch August 20, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DateTime parameters are treated as string

3 participants