Potential fix for code scanning alert no. 65: Incomplete string escaping or encoding #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Christopher Birnie-Browne <153604499+Git-Hub-Chris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Git-Hub-Chris/MicrosoftVsCode/security/code-scanning/65
To fix the problem, we should replace the use of
elm.replace("*", "")with a version that only removes the"*"marker if it is at the start of the string, and that is robust against branch names with asterisks elsewhere. The best approach is to use a regular expression that removes a leading asterisk, e.g.,elm.replace(/^\*/, "")(or perhapselm.replace(/^\*\s*/, "")to allow for optional whitespace). This ensures only the marker (not an asterisk contained in the branch name) is removed. This change should be made only on line 28 of extensions/terminal-suggest/src/completions/upstream/pnpm.ts. No new imports or major refactoring are needed; just update the usage of.replace()to use a regex.Suggested fixes powered by Copilot Autofix. Review carefully before merging.