Potential fix for code scanning alert no. 41: Useless regular-expression character escape #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion character escape Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Christopher Birnie-Browne <153604499+Git-Hub-Chris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Git-Hub-Chris/MicrosoftVsCode/security/code-scanning/41
The problem is that in the argument to
RegExp, the string\.${replaceeScope}only escapes the dot if written as'\\.' + replaceeScopeor`\\.${replaceeScope}`, because in a JavaScript string,\.is just., and in a regex pattern,.is a wildcard, not a literal dot. So to produce a regex that matches a literal dot, we need a double backslash in the JavaScript string, so that the regex engine sees a single backslash and interprets\.as a literal dot.To fix this, change line 12 to:
This ensures the resulting regex is matching a literal dot followed by the same replacement scope (like
.json), rather than any character plus the replacement scope.No other parts of the code need to be changed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.