Potential fix for code scanning alert no. 93: DOM text reinterpreted as HTML #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Christopher Birnie-Browne <153604499+Git-Hub-Chris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Git-Hub-Chris/MicrosoftVsCode/security/code-scanning/93
To fix the problem, you should further restrict the use of SVG images in data URIs for the
img.srcattribute, because SVGs can contain JavaScript and other active content that can result in XSS vulnerabilities if not thoroughly sanitized. The single best change is to update theisSafeImageSrc()function to disallow SVG images in data URIs, or, if SVG images must be supported, ensure comprehensive sanitization before using them as an image source. In this context, the most effective fix is to removesvg+xmlfrom the list of allowed media types in data URIs.This change needs to be made in the file
extensions/media-preview/media/imagePreview.js, specifically the regex on line 336 in theisSafeImageSrc()function. No new imports are needed, and you do not need to introduce any new variables or logic outside of updating this function.Suggested fixes powered by Copilot Autofix. Review carefully before merging.