Potential fix for code scanning alert no. 14: Incomplete string escaping or encoding #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Christopher Birnie-Browne <153604499+Git-Hub-Chris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Git-Hub-Chris/MicrosoftVsCode/security/code-scanning/14
To fix the incomplete escaping, the code should also escape backslash characters in addition to asterisks. The safest approach is to escape all backslashes first, before escaping any other metacharacters (like asterisks), to avoid double-escaping or other confusion. This can be done by first replacing all backslash (
\) characters with double-backslash (\\), and then escaping asterisks by replacing*with\*, both using global regular expressions. Only lines directly related to the escaping should be edited (line 759:const escapedName = ...). No extra imports are necessary because thereplacemethod and regular expressions are native in JavaScript/TypeScript.Suggested fixes powered by Copilot Autofix. Review carefully before merging.