feat: ETL sync steps for cities, space stations, outposts, and POIs#217
Merged
Conversation
- CitiesSyncStep: syncs /cities; error-skips records with no resolvable planet or moon - SpaceStationsSyncStep: syncs /space_stations; error-skips records with null/unknown orbit (required FK) - OutpostsSyncStep: syncs /outposts; all location FKs optional; warns when no planet or moon resolves - PoisSyncStep: syncs /pois; 9 parent FK lookups; warns when no location parent resolves at all - All steps registered in CatalogEtlModule providers and CatalogEtlService ETL_STEPS pipeline - 62 unit tests covering happy path, orphan parent handling, and upsert idempotency for all four steps
…isSyncStep mocks to CatalogEtlService test module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193
Summary
/cities): loads 6 parent FK sets in parallel; error-skips records where both planet and moon are unresolvable (location required)/space_stations): loads 7 parent FK sets; error-skips records with null or unknownorbit_id(required FK for space stations)/outposts): all location FKs optional; warns (does not skip) when no planet or moon resolves/pois): 9 parent FK lookups (most complex step); warns when no location parent at all resolvesCatalogEtlModuleproviders and appended toCatalogEtlService.ETL_STEPSin dependency order (cities before space stations, since space stations reference cities)Test plan
pnpm test --testPathPattern="catalog-etl/steps")