Skip to content

Fix a security warning on the CI #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

Fix a security warning on the CI #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
527cf18
fix(deployment): Fix naming and some conditions
timothedelion Nov 13, 2025
5400520
fix(ci): Fix a security warning
timothedelion Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,6 @@ jobs:
helm template mcp-server ./helm/mcp-server \
--values ./helm/mcp-server/examples/values-production.yaml

- name: Validate secops values
run: |
echo "Validating helm/mcp-server/examples/values-secops.yaml..."
helm template mcp-server ./helm/mcp-server \
--values ./helm/mcp-server/examples/values-secops.yaml

- name: Lint Helm Chart
run: |
echo "Linting Helm chart..."
Expand All @@ -104,11 +98,12 @@ jobs:
- name: Set up Helm
uses: azure/setup-helm@v4
with:
version: latest
# the latest version break on helm plugin install https://github.com/helm-unittest/helm-unittest.git
version: 3.19.0

- name: Install Helm Unittest Plugin
run: |
helm plugin install https://github.com/helm-unittest/helm-unittest.git --verify=false
helm plugin install https://github.com/helm-unittest/helm-unittest.git

- name: Run Helm unit tests
run: |
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,30 +104,32 @@ jobs:

- name: Push Helm Chart to OCI Registry
run: |
helm registry login ${{ env.REGISTRY }} \
echo ${{ secrets.GITHUB_TOKEN }} | helm registry login ${{ env.REGISTRY }} \
-u ${{ github.actor }} \
-p ${{ secrets.GITHUB_TOKEN }}
--password-stdin

CHART_VERSION=$(grep "^version:" ./helm/mcp-server/Chart.yaml | cut -d' ' -f2 | tr -d '"')
REPO_OWNER=$(echo '${{ github.repository_owner }}' | tr '[:upper:]' '[:lower:]')

helm push "${{ steps.package.outputs.chart-path }}" \
oci://${{ env.REGISTRY }}/${{ github.repository_owner }}/helm-charts
oci://${{ env.REGISTRY }}/${REPO_OWNER}/helm-charts

echo "✅ Chart published to: ${{ env.REGISTRY }}/${{ github.repository_owner }}/helm-charts:${CHART_VERSION}"
echo "✅ Chart published to: ${{ env.REGISTRY }}/${REPO_OWNER}/helm-charts:${CHART_VERSION}"

- name: Create summary
run: |
CHART_VERSION=$(grep "^version:" ./helm/mcp-server/Chart.yaml | cut -d' ' -f2 | tr -d '"')
REPO_OWNER=$(echo '${{ github.repository_owner }}' | tr '[:upper:]' '[:lower:]')
echo "## ✅ Helm Chart Released" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "Chart: mcp-server" >> $GITHUB_STEP_SUMMARY
echo "Version: ${CHART_VERSION}" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "Published to: \`oci://${{ env.REGISTRY }}/${{ github.repository_owner }}/helm-charts\`" >> $GITHUB_STEP_SUMMARY
echo "Published to: \`oci://${{ env.REGISTRY }}/${REPO_OWNER}/helm-charts\`" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "Install with:" >> $GITHUB_STEP_SUMMARY
echo '```bash' >> $GITHUB_STEP_SUMMARY
echo "helm pull oci://${{ env.REGISTRY }}/${{ github.repository_owner }}/helm-charts/mcp-server --version ${CHART_VERSION}" >> $GITHUB_STEP_SUMMARY
echo "helm pull oci://${{ env.REGISTRY }}/${REPO_OWNER}/helm-charts/mcp-server --version ${CHART_VERSION}" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY

publish-to-pypi:
Expand Down
Loading
Loading