chore(models): change certain fields to str #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
==========================================
- Coverage 95.63% 95.60% -0.03%
==========================================
Files 5 5
Lines 1236 1230 -6
==========================================
- Hits 1182 1176 -6
Misses 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kash-jay
force-pushed
the
kjayasekera/change-fields-to-string
branch
from
0d2c1ac to
eca6ee3
Compare
agateau-gg
reviewed
Nov 14, 2025
pygitguardian/models.py
Outdated
| OccurrenceKind = Literal["realtime", "historical"] | ||
| OccurrencePresence = Literal["present", "removed"] | ||
| Visibility = Literal["private", "internal", "public"] | ||
| Presence = str |
Collaborator
There was a problem hiding this comment.
I think you can remove this line.
kash-jay
force-pushed
the
kjayasekera/change-fields-to-string
branch
from
eca6ee3 to
e0d8566
Compare
agateau-gg
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR changes the following fields to str:
visibility,kind,presence status,ignore_reason,tag. This is done to prevent errors when changes are made in GIM, because expected values now do not have to be updated for every change.