Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Conversation

@LucianoPAlmeida
Copy link
Collaborator

Hey guys :)
I think this fixes #1454

@rnystrom
Copy link
Member

Looks great, let’s do it!

Sent with GitHawk

@rnystrom rnystrom merged commit 12fb61a into GitHawkApp:master Feb 20, 2018
@LucianoPAlmeida
Copy link
Collaborator Author

Hey @rnystrom there's some reason for the CI does not run in the PR's ?

@SD10
Copy link
Member

SD10 commented Feb 20, 2018

@LucianoPAlmeida we have to turn on a setting in buddy build that allows PRs from forks to be built automatically. GitHawk CI is kinda all over the place right now as everyone is trying to find a new, reliable provider

@LucianoPAlmeida
Copy link
Collaborator Author

I see :)
Thank's @SD10 👍

@rnystrom
Copy link
Member

Aha, thanks @SD10. Now that we’re moving to Bitrise I’ll see if that’s a thing.

Sent with GitHawk

@rnystrom
Copy link
Member

Hmm I do have builds setup for PRs, and this answer makes it clear that this is supposed to work. Next time we have a fork PR I'll see what's up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some IGListKit Objective-C files don't have code highlighting

3 participants